chore: use mockk instead of mockito in data pipelines

customerio / customerio-android

This is the official Customer.io SDK for Android.

MIT License

11 stars 9 forks source link

chore: use mockk instead of mockito in data pipelines #349

Closed mrehan27 closed 1 month ago

mrehan27 commented 1 month ago

part of: MBL-215

Background

I noticed we have been using both Mockito and MockK in Data Pipelines module. While this isn't necessarily an issue, we should only use both if needed. For functionalities that can be handled by both, we should stick to our preferred choice for consistency. I prefer MockK over Mockito because:

Our project codebase is mostly Kotlin
MockK is more Kotlin-friendly and easier to integrate
It has a DSL-like syntax and is easy to adopt in Kotlin
It allows mocking/spying methods for final classes

I haven't removed Mockito from the module yet, I only updated it to see how it works. If everything goes well, we can later remove Mockito from the module/project.

Changes

Used MockK for mocking objects instead of Mockito
Replaced verification and mocking calls from Mockito with MockK

github-actions[bot] commented 1 month ago

# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/test-improvements-part-3 (1716828011)` * kotlin_compose: `rehan/test-improvements-part-3 (1716828010)`

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.54%. Comparing base (48c64c9) to head (72de5cb). Report is 39 commits behind head on feature/cdp.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/cdp #349 +/- ## ================================================= - Coverage 54.45% 52.54% -1.92% + Complexity 282 272 -10 ================================================= Files 109 101 -8 Lines 2534 2394 -140 Branches 355 339 -16 ================================================= - Hits 1380 1258 -122 + Misses 1032 1019 -13 + Partials 122 117 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Build available to test Version: rehan-test-improvements-part-3-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 1 month ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅