customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

feat: do not show modal message if screen changes and page rule mismatches #355

Closed mrehan27 closed 3 months ago

mrehan27 commented 4 months ago

part of MBL-353

Changes

Note

Tests are added in #357

github-actions[bot] commented 4 months ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-353-in-app-fix (1718394486)` * kotlin_compose: `rehan/mbl-353-in-app-fix (1718394490)`
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 5.55556% with 85 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (d9388a3) to head (8469c61).

Files Patch % Lines
...stomer/messaginginapp/gist/presentation/GistSdk.kt 8.10% 34 Missing :warning:
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% 16 Missing :warning:
...stomer/messaginginapp/gist/data/listeners/Queue.kt 18.18% 9 Missing :warning:
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% 9 Missing :warning:
...ssaginginapp/gist/presentation/GistModalManager.kt 0.00% 8 Missing :warning:
...gist/presentation/engine/EngineWebViewInterface.kt 0.00% 7 Missing :warning:
...tomer/messaginginapp/gist/presentation/GistView.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #355 +/- ## ============================================ - Coverage 54.32% 52.86% -1.46% Complexity 282 282 ============================================ Files 109 109 Lines 2511 2582 +71 Branches 355 366 +11 ============================================ + Hits 1364 1365 +1 - Misses 1025 1095 +70 Partials 122 122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Build available to test Version: rehan-mbl-353-in-app-fix-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

github-actions[bot] commented 4 months ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

levibostian commented 4 months ago

Code LGTM.

I suggest that before merging, check this test case I wrote and make sure it passes with this implementation.

mrehan27 commented 3 months ago

PR is updated and ready for review.