customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
11 stars 9 forks source link

chore: move lifecycle observer to core module #368

Closed mrehan27 closed 2 days ago

mrehan27 commented 1 week ago

part of: MBL-337

Changes

Not Included

Tests updates are not included in this PR, will be updated in another ticket specific to test structure

github-actions[bot] commented 1 week ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-337-push-lifecycle (1719906313)` * kotlin_compose: `rehan/mbl-337-push-lifecycle (1719906313)`
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 18.92%. Comparing base (bfd8e28) to head (3b87512). Report is 54 commits behind head on feature/cdp.

Files Patch % Lines
...stomer/messaginginapp/gist/presentation/GistSdk.kt 0.00% 7 Missing :warning:
...o/customer/messagingpush/ModuleMessagingPushFCM.kt 58.33% 5 Missing :warning:
.../customer/messagingpush/di/DiGraphMessagingPush.kt 80.00% 0 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (bfd8e28) and HEAD (3b87512). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (bfd8e28) | HEAD (3b87512) | |------|------|------| ||4|3|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/cdp #368 +/- ## ================================================== - Coverage 52.86% 18.92% -33.94% + Complexity 282 60 -222 ================================================== Files 109 39 -70 Lines 2582 1157 -1425 Branches 366 175 -191 ================================================== - Hits 1365 219 -1146 + Misses 1095 914 -181 + Partials 122 24 -98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

Build available to test Version: rehan-mbl-337-push-lifecycle-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

mrehan27 commented 1 week ago

@Shahroz16 Good point, but I'm not much concerned about it because

We can still check on modules count and skip listener if needed. But I see this being more error-prone and adding less value, so would not suggest to go with it.

github-actions[bot] commented 1 week ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅