Closed mrehan27 closed 2 days ago
Attention: Patch coverage is 45.83333%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 18.92%. Comparing base (
bfd8e28
) to head (3b87512
). Report is 54 commits behind head on feature/cdp.
:exclamation: There is a different number of reports uploaded between BASE (bfd8e28) and HEAD (3b87512). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (bfd8e28) | HEAD (3b87512) | |------|------|------| ||4|3|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Build available to test
Version: rehan-mbl-337-push-lifecycle-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/
@Shahroz16 Good point, but I'm not much concerned about it because
main
today, so we are not adding anything extra with the changeWe can still check on modules count and skip listener if needed. But I see this being more error-prone and adding less value, so would not suggest to go with it.
No changes detected in SDK binary size ✅
part of: MBL-337
Changes
ActivityLifecycleCallbacks
observer tocore
module so any module can listen to itpush
andin-app
module to observe newly added lifecycle callback fromcore
Not Included
Tests updates are not included in this PR, will be updated in another ticket specific to test structure