search

customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
11 stars 9 forks source link

chore: decouple common-test from tracking #373

Closed mrehan27 closed 1 day ago

mrehan27 commented 2 days ago

part of MBL-394

Background

Since the changes in this ticket will cause some modules' tests to fail compilation until the changes are complete, this PR is created to hold all changes for the ticket until we merge it into base feature branch. All future PRs will be created on top of it. Once the stack is complete and merged, we'll merge this into the base feature branch so all modules can compile and run successfully.

Changes

PR Stack

github-actions[bot] commented 2 days ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `rehan/mbl-394-refactor-base (1720042783)` * kotlin_compose: `rehan/mbl-394-refactor-base (1720042782)`
github-actions[bot] commented 2 days ago

Build available to test Version: rehan-mbl-394-refactor-base-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.90%. Comparing base (bfd8e28) to head (869c09e). Report is 57 commits behind head on feature/cdp.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/cdp #373 +/- ## ================================================== + Coverage 52.86% 90.90% +38.04% ================================================== Files 109 1 -108 Lines 2582 11 -2571 Branches 366 2 -364 ================================================== - Hits 1365 10 -1355 + Misses 1095 1 -1094 + Partials 122 0 -122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 days ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

mrehan27 commented 1 day ago

@Shahroz16 Actually yes, it was giving me OCD too 😂 But the main reason for this PR was to keep it very small and use it as placeholder for merging future PRs for these changes. So we don't break feature branch and can merge all changes together to ensure tests are compiling and working.