customerio / customerio-android

This is the official Customer.io SDK for Android.
MIT License
13 stars 9 forks source link

fix: add userId for deleteToken #441

Closed Shahroz16 closed 2 months ago

Shahroz16 commented 2 months ago

closes: MBL-528: Android SDK should consistently add userId in delete token payload

Since event are asynchronous, we can have userId null before deleteDevice access the value of userId. So we should enrich the delete device event with userId so it always have that value.

github-actions[bot] commented 2 months ago
# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `shahoz-mbl-528 (1727253751)` * kotlin_compose: `shahoz-mbl-528 (1727253759)`
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature/react-native-cdp@0f20226). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ines/src/main/kotlin/io/customer/sdk/CustomerIO.kt 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/react-native-cdp #441 +/- ## =========================================================== Coverage ? 51.96% Complexity ? 291 =========================================================== Files ? 96 Lines ? 2259 Branches ? 353 =========================================================== Hits ? 1174 Misses ? 982 Partials ? 103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

github-actions[bot] commented 2 months ago

Build available to test Version: shahoz-mbl-528-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/