chore: Improve public settings screen UX

customerio / customerio-android

This is the official Customer.io SDK for Android.

MIT License

13 stars 9 forks source link

chore: Improve public settings screen UX #453

Closed mahmoud-elmorabea closed 1 month ago

mahmoud-elmorabea commented 1 month ago

This PR is one of series of PRs that update the UX of the settings page for the Java_Layout sample app.

PR stack:

Create a new internal settings screen -> #452
Update public settings screen -> This PR
Update theme to new brand -> #454

Notes:

I will collect all changes in a base branch update-settings-page-ux and then merge them as one chore to the main branch
Choosing chore not to trigger an SDK release when this is merged

The general idea of the improvements is to have our settings screen map as close as possible to the configuration of our SDK when it's being initialized. You can see how closely the fields in this public settings screen map to the config:

The UI was tested on multiple devices

Phone - API 35	Phone - API 21	Tablet

Video of how it works

public-settings-page.webm

github-actions[bot] commented 1 month ago

# Sample app builds 📱 Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. --- * java_layout: `update-public-settings-screen (1729000443)` * kotlin_compose: `update-public-settings-screen (1729000445)`

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (update-settings-page-ux@ffa1f75). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## update-settings-page-ux #453 +/- ## ========================================================== Coverage ? 51.21% Complexity ? 287 ========================================================== Files ? 95 Lines ? 2269 Branches ? 353 ========================================================== Hits ? 1162 Misses ? 1007 Partials ? 100 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

github-actions[bot] commented 1 month ago

Build available to test Version: update-public-settings-screen-SNAPSHOT Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

mahmoud-elmorabea commented 1 month ago

@mrehan27 Yes, I will have follow up PRs for changes to login page and other parts