search

customerio / customerio-expo-plugin

MIT License
11 stars 9 forks source link

fix: update nse class name to avoid conflicts with other libraries #119

Closed ami-aman closed 11 months ago

ami-aman commented 11 months ago

helps: https://github.com/customerio/customerio-expo-plugin/issues/118

The customer is having issues when multiple libraries have same class name such as NotificationService in NotificationServiceExtension target. The customer specifically mentioned about OneSignal and our expo plugin showing conflicts because of the same class name.

darnfish commented 11 months ago

I think you might need to rename the actual file names too :~) but looking good - thank you so much!

ami-aman commented 11 months ago

Reason of closing the PR - https://github.com/customerio/customerio-expo-plugin/issues/118#issuecomment-1866448559