customerio / customerio-expo-plugin

MIT License
11 stars 9 forks source link

feat: rich push environment variable setup #23

Closed xtreem88 closed 1 year ago

xtreem88 commented 1 year ago

This PR resolves: https://github.com/customerio/issues/issues/8922 and also inherits changes from https://github.com/customerio/customerio-expo-plugin/pull/15

Users can provide the following details:

"env": {
  "siteId": "94541e1bbff594682089",
  "apiKey": "914ea21ebfa87bf771f4",
  "region": "us"
}

These details would be used to setup the rich push workaround

ami-oss-ci commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
ami-ci commented 1 year ago

:tada: This PR is included in version 1.0.0-alpha.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ami-ci commented 1 year ago

:tada: This PR is included in version 1.0.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

smlarkin commented 1 year ago

This PR resolves: https://github.com/customerio/issues/issues/8922 and also inherits changes from #15

Users can provide the following details:

"env": {
  "siteId": "94541e1bbff594682089",
  "apiKey": "914ea21ebfa87bf771f4",
  "region": "us"
}

These details would be used to setup the rich push workaround

@xtreem88 @ami-aman ...

Can anyone tell me where I find these keys ( siteId, apiKey, region ) ?

Are they specific to the app in App Store Connect, my Apple Developer Account, or Customer.io ?

Your docs also do not indicate this or point in any direction ( see attached ) .

customerIO_Expo

Thanks in advance.

smlarkin commented 1 year ago

@xtreem88 @ami-aman Also, I believe your Repo & Docs are outdated since this PR is merged. Specifically, it seems that the direction to alter the ios/NotificationService/NotificationService.swift would no longer be necessary -- Is that true ?

xtreem88 commented 1 year ago

Hello @smlarkin Thanks for the feedback. To find your API credentials, see this doc: https://customer.io/docs/managing-credentials/#where-can-you-find-them We do need to be clearer in our Expo docs about this. We will make some changes to fix that. To answer your second question, the docs and repo are up to date, and the file still exists in our repo. Are you having any issues with the plugin? I can help you if you need help.