Closed xtreem88 closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.1.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Hey, there @xtreem88 👋🤖. I'm a bot here to help you.
⚠️ Pull requests into the branch beta
typically only allows changes with the types: fix
. From the pull request title, the type of change this pull request is trying to complete is: feat
. ⚠️
This pull request might still be allowed to be merged. However, you might want to consider make this pull request merge into a different branch other then beta
.
Please merge !
:tada: This PR is included in version 1.0.0-beta.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Resolves: https://github.com/customerio/issues/issues/8792
This adds support for iOS SDk v2 only.
QA Instructions
expo prebuild --clean
expo prebuild --clean
for each versionios.disableNotificationRegistration
totrue
and thenfalse
and also leave it outExpected Result
Prebuild should only be successful only on RN SDK with iOS SDK v2 or higher. RN SDK with iOS SDK lower than v2 should throw an error relating to dependencies. The code for registering push notification should only be added when
ios.disableNotificationRegistration
is set tofalse