customerio / customerio-expo-plugin

MIT License
11 stars 9 forks source link

FCM integration #56

Open zdnk opened 1 year ago

zdnk commented 1 year ago

Hello,

we have all tokens from FCM for iOS as well and we would like to import them in Customer.IO. However we also need to collect the new tokens as FCM tokens if I understand correctly because you cannot configure CustomerIO to send it as ASPN to some users as FCM to others right?

When is the integration planned?

ami-aman commented 1 year ago

Hi @zdnk

Our Expo config plugin currently only support APNS for iOS and FCM for Android.

We have FCM integration request on our roadmap and have added your vote to the request. We will notify you when this is prioritized. Thanks for your feedback. We really appreciate it !

zdnk commented 1 year ago

What if I manually call CustomerIO.registerDeviceToken in javascript with the FCM token? Will that work?

ami-aman commented 1 year ago

I am afraid that might lead to device token conflict i.e you will register FCM token using javascript and native module would generate an APNS token and register it.

zdnk commented 1 year ago

even if I have in my Expo project in the app.config.js disabled the notification registration?

ios: {
          useFrameworks: 'static',
          disableNotificationRegistration: true,
}
ami-aman commented 1 year ago

Yes, even if you have disableNotificationRegistration : true then also this workaround might not work as expected. AppDelegate.m or AppDelegate.mm file would have delegate methods for APNS and if you attempt to send a FCM push notification, your device might never receive it. Let me know if you need more clarity on this. I would be happy to explain further.

zdnk commented 1 year ago

Ok. What can I do to make it work somehow? Because unfortunately we are using firebase and we have been using it with the old app version as well. I am open to suggestion where our backend register the devices in the customerio. But I need some solution :)

ami-aman commented 1 year ago

@zdnk

I apologies for the delay.

As a temporary solution, you could refer to the steps outlined in our React Native documentation. Ensure that you select FCM as you are using it for push notifications and choose either Objective-C or Swift based on your project. However, please note that the drawback of this workaround is that the changes made will only persist until you execute the 'prebuild --clean' command.

Do let us if this helps us. Feel free to comment if you need any assistance.

zdnk commented 1 year ago

Well, se are working with Expo managed for now. Using suggested solution by you does require bare workflow.

What about adding option to simply completely disable push notification registration? This would actually solve the issue as it will allow developers to use FCM manually as workaround like I am doing right now. And probably would be easy to implement, right?

zdnk commented 1 year ago

Any update here? Making it work together with Expo notifications would be also enough.

levibostian commented 1 year ago

Adding FCM support to our Expo plugin is continuing to be tracked and prioritized internally. We do not have any updates to share at this time. We will update this issue when we have updates to share.

Thank you, everyone!

zdnk commented 4 months ago

9 months later, whats the update?

levibostian commented 4 months ago

Thank you for following up on this feature request. We understand that waiting for updates can be frustrating, and we sincerely apologize for any inconvenience this may have caused.

Please know that we are continuing to track and prioritize this feature internally. Our team is dedicated to ensuring that we deliver high-quality updates, and this sometimes requires careful planning and evaluation to get things right.

Your feedback is incredibly important to us, and we truly appreciate your patience and understanding as we work through our development pipeline.

Have a great day!

billinghamj commented 2 months ago

This is looking to be a blocker for us also. Bit disappointing that this is taking so long

Nikit-Singh commented 2 months ago

Hey @levibostian, any updates on this?

pablogdcr commented 2 months ago

Also a blocker for us, please let us know if you have any updates on this!