search

customerio / customerio-expo-plugin

MIT License
11 stars 9 forks source link

Compatibility with Expo 48 #57

Closed jbtheard closed 1 year ago

jbtheard commented 1 year ago

Doc only mentions expo 45 and 46 but expo 47 has been released in Nov 2022 and Expo in Feb 2023. What about supporting them ? It's not helpful to make this plugin available if not maintained.

For instance, I don't think point 3 in the install/config section is needed any more as expo natively requires iOS 13 from v47 (as per here)

ami-aman commented 1 year ago

Hi @jbtheard

Our team has done internal testing on Expo version 47 and 48 as well, hence we do support all the versions you mentioned in your comment. Are you facing any issues running the plugin on Expo version 47 and 48 ?

jbtheard commented 1 year ago

I'm still trying to figure out how to make it work. I don't expect any specific issues related to 48 but worth updating the doc on your side if it has indeed been tested. Please five me a few days to eventually report back here.

ami-aman commented 1 year ago

Thank you for your feedback, @jbtheard ! I really appreciate it !

I apologise that our docs are not updated but I want to assure you that we are working hard day after day to keep all our docs up-to-date. I would be glad to hear more feedbacks from you in case you have any. Your comments help us do better !

jbtheard commented 1 year ago

Happy to make expo work better for all!

As suggested here, I didn't realise you had both a readme.md in this repo and an official page on your domain (that only slightly differs). First suggestion would be to point to your domain for any doc ;)

levibostian commented 1 year ago

I talked to our Expo developers on the team and they mentioned that they have tested the Expo plugin with Expo version 48. I have submitted a docs update to say that we support version 48.

Because of this, I will close this issue.

Anyone can feel free to comment on the issue if they have questions or comments.