search

customerio / customerio-expo-plugin

MIT License
11 stars 9 forks source link

fix: resolve issues with saving the project file async #73

Closed euc-callum closed 1 year ago

euc-callum commented 1 year ago

See https://github.com/customerio/customerio-expo-plugin/issues/72.

This change ensures that the Expo plugin returns any changes that it makes to the project file rather than saving these asynchronously (and not awaiting the result).

euc-callum commented 1 year ago

Is this likely to make it in @levibostian?

sergey-king commented 1 year ago

I also need this. Subscribed

euc-callum commented 1 year ago

Tagging another maintainer, apologies @xtreem88 but you seem active in here.

euc-callum commented 1 year ago

Actually looks like you're trying to do something similar @xtreem88, might be a duplication of work here?

https://github.com/customerio/customerio-expo-plugin/pull/76

xtreem88 commented 1 year ago

@euc-callum Thanks for the PR; I've been away for some days; I was moving. I created a new PR based on your recommendation here, The PR builds on top of changes you made here and also has Appdelegate Subscriber. I merged both changes to be tested and QA as one release.

euc-callum commented 1 year ago

Thanks for the heads up @xtreem88, I've commented on your pull request because I believe it may still have the issue I have resolved in this pull request.

Can I advise merging in this pull request as it is known to work (sample size of 1 - we're running this change in production now)?

It would also be nice to receive credit for the contribution 🙂

sergey-king commented 1 year ago

@xtreem88 when can we expect a new release including this fix? We would also appreciate another week of trial since these issues/bugs have prevented us from pushing this along.

StephMoreno commented 1 year ago

Hi @sergey-king, I'm Stephanie, a Product Manager here. I'm sorry to hear about the challenges and blockers this has created for you. Regarding the extension of your free trial, can you please send us an email about this to win@customer.io? Our support team will be able to assist you there regarding your trial.