customerio / customerio-reactnative

MIT License
23 stars 11 forks source link

fix: autoupdate to latest major version of iOS SDK #124

Closed levibostian closed 1 year ago

levibostian commented 1 year ago

This will need tested in Ami to confirm that our SDK is compatible with latest native iOS SDK.

QA builds being created over in the Ami RN github repo

QA

iOS Ami RN app build to QA test with: levi/auto-update-ios (1682348352)

QA steps:

This PR updates the native iOS SDK version that is used by the RN SDK. In order for this PR to pass QA, we need to run the smoke test suite to confirm the SDK functionality is stable. This PR does not add any new features or bug fixes to the RN SDK. We simply need to test existing SDK functionality to assert that there are not issues.

github-actions[bot] commented 1 year ago

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...
This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format: ``` : short description of change being made ``` **If your pull request [introduces breaking changes](https://web.archive.org/web/20220725195319/https://nordicapis.com/what-are-breaking-changes-and-how-do-you-avoid-them/)** to the code, use this format: ``` !: short description of breaking change ``` where `` is one of the following: - `feat:` - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project. - `fix:` - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project. - `docs:` - This pull request is making documentation changes, only. - `refactor:` - A change was made that doesn't fix a bug or add a feature. - `test:` - Adds missing tests or fixes broken tests. - `style:` - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc) - `perf:` - Changes improve performance of the code. - `build:` - Changes to the build system (maven, npm, gulp, etc) - `ci:` - Changes to the CI build system (Travis, GitHub Actions, Circle, etc) - `chore:` - Other changes to project that don't modify source code or test files. - `revert:` - Reverts a previous commit that was made. ### Examples: ``` feat: edit profile photo refactor!: remove deprecated v1 endpoints build: update npm dependencies style: run formatter ``` Need more examples? Want to learn more about this format? [Check out the official docs](https://www.conventionalcommits.org/). **Note:** If your pull request does multiple things such as adding a feature _and_ makes changes to the CI server _and_ fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.
jasonto commented 1 year ago

Not able to receive push notification with build levi/auto-update-ios (1682452762)

ami-aman commented 1 year ago

Not able to receive push notification with build levi/auto-update-ios (1682452762)

Fixed this, @jasonto ! You should be able to receive push notifications now. Let me know if you still do not.

Shahroz16 commented 1 year ago

I am merging it to unblock customers. We have tested and it seems to work, Jason was able to make it work but was having issues with not getting push notifications on APN, which was down to configuration issue and not SDK.