Closed levibostian closed 1 year ago
Pull request title looks good 👍!
If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.0
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Ready for re-review.
Also, I improved the speed from 10 seconds to ~3 seconds.
When you make an update to the SDK source code and you want to test that change in one of the sample apps, you have to run
yarn update customerio-reactnative
to force yarn to re-install the local copy of the SDK. This step takes many minutes to run and slows down development.I used
--verbose
the last time I ranyarn update...
and noticed that mostly why it was taking so long was that yarn was installing and caching the sample apps and all of it's subdirectories. This is what was taking up too much time during install.So, this refactor uses
npm pack
to build the SDK with only the files that are needed to install the SDK. We then tell npm to install the CIO SDK from the built .tgz file instead of../../
.From testing, you can now update the local RN SDK source code in a sample app in ~3 seconds. It used to be between 5-10 minutes for me.