Closed levibostian closed 12 months ago
Pull request title looks good 👍!
If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0
. If this pull request gets merged in, the next release of this project will be 1.0.1
. This pull request is not a breaking change.
All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.
Hey guys! Any updates on when this is going to be merged?
@gerjunior-groundswell, this has been deployed in 3.1.8
. Thank you for your patience while we test the change before merging. Enjoy!
The RN SDK today does require the messagingpush SDK module but the podspec that we ask customers to install does not include this module. This could mean compile-time errors.
Yes, we do expect that customers setup rich push in their app and so we do not expect customers to encounter this problem. However, the idea that this PR also adds a comment to the podspec files specifying required dependencies is a good value add to the codebase.
PR in draft mode and asks for review by team to get feedback if this is something we want to do or not.
Note: Conversation that sparked this idea: https://github.com/customerio/docs/pull/1446#discussion_r1298239891