search

customerio / customerio-reactnative

MIT License
23 stars 11 forks source link

feat: using forked segment library in cio-rn package #219

Closed ami-aman closed 8 months ago

ami-aman commented 9 months ago

Refers [CDP] RN iOS: Fork & Integrate Segment React Native SDK #11653

NOTE

This pull request gets merged into main_cdp_rn and not main to avoid releases before CDP work is complete and well tested. If anyone in the squad feels not aligned with this reason then please feel free to suggest a change.

ami-aman commented 9 months ago

@mrehan27 @Shahroz16 @levibostian Since this PR is approved but CI tests are failing due to some yarn issues. I tried clearing yarn cache and updating checksums along with other attempts but nothing helped. Does anyone have an idea why the PR isn't passing the tests?

mrehan27 commented 9 months ago

@ami-aman Not sure. But probably because we mostly use npm install locally and Github action is using yarn install --frozen-lockfile. Did you try removing node_modules and running yarn install --frozen-lockfile on your local machine to get some clue?

levibostian commented 9 months ago

I think I got it fixed in the commit I just pushed.

I fixed it by modifying the package.json file to using a commit hash instead of a git branch as it was set to before.

By theory is that by using a git commit hash, the lock file (should) stay up-to-date no matter what the future holds for branch aman/fork-integrate-11653. If we used a branch name, then if you pushed new commits to that branch or deleted that branch, then yarn install would fail again.