customink / secondbase

Seamless second database integration for Rails.
MIT License
220 stars 30 forks source link

Add support for abort if pending #12

Closed hmadison closed 8 years ago

hmadison commented 8 years ago

Resolves #7

cc @metaskills

metaskills commented 8 years ago

Nice! I have often considered the abort_if_pending_migrations kind of private that other's call. Would the test still work if we called test:prepare or maybe even test on the dummy app?

hmadison commented 8 years ago

@metaskills It would, but i'm trying to hook in places that won't cause some kind of astonishment later down the road. While abort_if_pending_migrations may be private, we already dig into some private apis to make this gem work and I rather pick the more logical but private hook if i can.

metaskills commented 8 years ago

Roger roger.