Add support and tests for the schema sql format

customink / secondbase

Seamless second database integration for Rails.

MIT License

220 stars 30 forks source link

Add support and tests for the schema sql format #13

Closed hmadison closed 8 years ago

hmadison commented 8 years ago

Resolves #8

cc @metaskills

metaskills commented 8 years ago

Did you notice the binding.pry failures?

hmadison commented 8 years ago

yeah fixed.

metaskills commented 8 years ago

I really like the way that tests reads. Amazing how fat SecondBase.on_base is getting too.

hmadison commented 8 years ago

@metaskills Its a side effect of the global state we need to dig into to get this to work. I don't think there is a easy way to fix it unless we got stuff upstreamed.

metaskills commented 8 years ago

Yea... I don't have issues with it... was just wondering if there were downsides if we consider on_base public. I'm not seeing anything but will think about it more.