Support Rails 4.2 Test DB Sync Strategy

customink / secondbase

Seamless second database integration for Rails.

MIT License

220 stars 30 forks source link

Support Rails 4.2 Test DB Sync Strategy #20

Closed metaskills closed 8 years ago

metaskills commented 8 years ago

Confirmed with this commit in the ENCOM test application. https://github.com/customink/encom_dbs/commit/6c46cf1155f1316e8c77ef14d2614f57b590ec44 After including second_base/test_help:

$ rails generate second_base:migration CreateUsers email:string timestamps
$ rake db:migrate
$ rake test

And migrations are automatically detected, db:test:prepare ran, and connections cleared and re-established. Epic success!

metaskills commented 8 years ago

cc @hmadison

metaskills commented 8 years ago

This final PR concludes my ENCOM integration testing. I can't find one thing wrong with this gem. If all tests pass, I think we are ready for a 1.0. Unless you want to do any of those other open issue?

hmadison commented 8 years ago

Yeah lets cut 1.0.0. I'm holding off on doing the fixture stuff till we see how badly its needed. I'm 90% sure most people will use a factory library over it.

metaskills commented 8 years ago

I agree on the fixtures too. Merged! Cut v1 when you are ready. Cheers.