search

customink / secondbase

Seamless second database integration for Rails.
MIT License
220 stars 31 forks source link

Rails 5 Support #30

Closed hmadison closed 8 years ago

hmadison commented 8 years ago

Resolves #29.

@metaskills everything works. I had to move some stuff around, not too sure what we want to do with the duplication.

metaskills commented 8 years ago

Just tested this branch with the ENCOM DBs test app https://github.com/customink/encom_dbs/tree/secondbase which uses Rails 4.2 and it all checks out. Well done! Love the duplicate dummy app for Rails 5. I just added an ApplicationRecord so we can be a bit more Rails 5 real. Also added Ruby 2.3 to TravisCI.

Lastly, can we just do a ⬆️✋ cause being able to support Rails 4.0 to 5.0 in one gem release means we kind of hit the sweet spot in architecture here. Love it!