Closed roolo closed 5 years ago
The original intent was not include these because we did not want to promote their explicit usage. Rather, you should run the Rails documented commands and these run silently in the background. But it may be hard to make these show up only when run_with_db_tasks
is set to false. That said, I like how adding the desc raises the ones we explicitly call out in this section (https://github.com/customink/secondbase#database-tasks) like db:second_base:migrate:redo
.
So all in all I think this is fine, but will bring on confusion when run_with_db_tasks
is set to true. Do you think it is possible to add a unless SecondBase::Railtie.config.run_with_db_tasks
(pseudo code) to the descriptions the task we do automatically?
@metaskills The original intent was not include these because we did not want to promote their explicit usage. Rather, you should run the Rails documented commands and these run silently in the background. But it may be hard to make these show up only when
run_with_db_tasks
is set to false. That said, I like how adding the desc raises the ones we explicitly call out in this section (https://github.com/customink/secondbase#database-tasks) likedb:second_base:migrate:redo
.So all in all I think this is fine, but will bring on confusion when
run_with_db_tasks
is set to true. Do you think it is possible to add aunless SecondBase::Railtie.config.run_with_db_tasks
(pseudo code) to the descriptions the task we do automatically?
For the linked tasks from README
Tasks are documented and these show up only when config.second_base.run_with_db_tasks = false
, in rake -T
Tasks are documented and these show up no matter what in rake -T
Tasks are documented, but the desc
s are commented
Thanks for merging @roolo! And more so for making those changes to conditionally show the desc based on the run_with_db_tasks
boolean. I'll do some work to update the CHANGELOG and version and quickly look thru other issues to see if anything should go into the next gem release.
(To show them in project using this gem)
The changes other than
desc
s are coming from running commands from Contributing section in README