Wrong particle information for 1.17.1

customrealms / core

Core library for the CustomRealms runtime

https://customrealms.io/core

MIT License

35 stars 13 forks source link

Wrong particle information for 1.17.1 #42

Open NexelOfficial opened 2 months ago

NexelOfficial commented 2 months ago

Particles SMOKE, LARGE_SMOKE and SMALL_SMOKE don't exist. See 1.17 API: https://helpch.at/docs/1.17/org/bukkit/Particle.html

Correct particles: SMOKE_NORMAL and SMOKE_LARGE

After playing around some more, pretty much all particles don't match up with the API.

NexelOfficial commented 2 months ago

I would really like to contribute to this project. You can find my portfolio at https://www.linkedin.com/in/nathandiepeveen. Please contact me at nathandiepeveen.nl@gmail.com.

mindflowgo commented 2 months ago

Why don't you start by looking at issues and then doing pull requests and fixing them Nexel? I'm not related to the project, but I agree it needs driven people like you to keep things improving.

connerdouglass commented 2 months ago

@NexelOfficial I see what you mean. We generate our typings from the SpigotMC docs: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Particle.html

I'm unsure why there is a discrepancy between these. If you have any ideas or more info, I'd appreciate the help.