search

cutbox / CutBox

CutBox makes your macOS pasteboard awesome.
https://cutbox.github.io
Other
168 stars 11 forks source link

Crash after typing anything that matches more than 2 letters in fuzzy search #90

Closed ulfgj closed 4 years ago

ulfgj commented 5 years ago

Issue description

Crash after typing anything that matches more than 2 letters in fuzzy search

Steps to reproduce the issue

1. 2. 3.

What's the expected result?

-

What's the actual result?

-

Additional details / screenshot

jasonm23 commented 5 years ago

Hi @ulfgi could you make sure you:

  1. Provide the CutBox version used (CutBox menu > About)
  2. Macos version & build (About this Mac)
  3. Clear your current history and try again
ulfgj commented 5 years ago

hi! clearing the history worked, but the issue reappeared after a couple of uses. older versions (tried 1.4.3 & 1.4.4) won't start at all.

CutBox 1.4.5 Mojave 10.14.6 (18G87) MacBook Pro (Retina, 15-inch, Mid 2014)

2,2 GHz Intel Core i7 16 GB 1600 MHz DDR3

Intel Iris Pro 1536 MB

On Tue, Aug 20, 2019 at 4:26 AM Jason Milkins notifications@github.com wrote:

Hi @ulfgi could you make sure you:

  1. Provide the CutBox version used (CutBox menu > About)
  2. Macos version & build (About this Mac)
  3. Clear your current history and try again

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KILYSBQ4U3D5T6BVOX7TQFNI3XA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4U3CVI#issuecomment-522826069, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7KILY3FB3CLBJOQ3VZDUTQFNI3XANCNFSM4IM33WKA .

jasonm23 commented 5 years ago

See #89 as to why older versions won't work.

I'll try and see if I can reproduce the problem

jasonm23 commented 5 years ago

Unable to reproduce, leaving open for more info and other users to report same issue

jasonm23 commented 5 years ago

If it's safe to do so, attach ~/Library/Preferences/info.ocodo.CutBox.plist (ensure there is no personal info, passwords etc.)

ulfgj commented 5 years ago

cool. i cleaned the history. i'll provide the file when it crashes again.

On Tue, Aug 20, 2019 at 1:28 PM Jason Milkins notifications@github.com wrote:

If it's safe to do so, attach ~/Library/Preferences/info.ocodo.CutBox.plist (ensure there is no personal info, passwords etc.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KIL6ZACVLYF5MGDMXVI3QFPIMVA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4V6RDY#issuecomment-522971279, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7KIL7NWQSFPMYKZ3W2OGLQFPIMVANCNFSM4IM33WKA .

ulfgj commented 5 years ago

attached is an example of a plist that causes a crashwhen i'm typing "en" in the fuzzy search. (file renamed to with extension .txt since .plist is not allowed as attachments in posts.) about 30 items currently in this history. limit set to 140.

info.ocodo.CutBox.plist.txt

jasonm23 commented 5 years ago

You'll need to attach via the GitHub interface

ulfgj commented 5 years ago

tnx. my post has been edited and file attached.

On Wed, Aug 21, 2019 at 3:41 AM Jason Milkins notifications@github.com wrote:

You'll need to attach via the GitHub interface

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KILZ5WSIXAVYVHQP5ZVDQFSMNNA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YFB2I#issuecomment-523260137, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7KILYQTEWG3MSJU6J7VDTQFSMNNANCNFSM4IM33WKA .

awreccan commented 5 years ago

me too

balazser commented 4 years ago

Unfortunately also crashes on my computer. The same issue as @ulfgj has.

macOs Mojave 10.14.6 (18G87) version: 1.4.5 (10219)

ulfgj commented 4 years ago

temp fix:

On Wed, Sep 25, 2019 at 11:35 AM Balazs Erdos notifications@github.com wrote:

Unfortunately also crashes on my computer.

macOs Mojave 10.14.6 (18G87) version: 1.4.5 (10219)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KILZUGLV64YW5YU4LGTTQLMWHTA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RILSI#issuecomment-534939081, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7KILYOFCDAHJ2IPGJ55WDQLMWHTANCNFSM4IM33WKA .

gonzalt03 commented 4 years ago

Me too.

macOS Mojave 10.14.6 (18G95) version: 1.4.5 (10219)

jasonm23 commented 4 years ago

My apologies for not solving this yet. I haven't had any time to devote to CutBox maintenance for a while.

Writing this to remind myself to set aside time this coming week.

jasonm23 commented 4 years ago

Btw @ulfgj that plist.txt file. Is that untouched?

ulfgj commented 4 years ago

Btw @ulfgj that plist.txt file. Is that untouched?

dunno if i know what that means... :/ i believe i edited away a big chunk of it before posting, though.

jasonm23 commented 4 years ago

Right, by untouched I do mean unedited.

I can't do a test with an edited plist.

It will have to be an unedited plist that causes CutBox to crash.

ulfgj commented 4 years ago

still trying to recreate a situation where it crashes, but it seems only to happen when i copy sensitive information from freshdesk. lol.

awreccan commented 4 years ago

I have this issue too. Would like to see it fixed soon, so is there anything I can do to help debug?

jasonm23 commented 4 years ago

I need a completey untouched CutBox data file that can provide a reproduction of the crash. It can be used as the fixture basis for an automated test.

awreccan commented 4 years ago

I'm not super familiar with MacOS. What's the file path? I can send it to you.

jasonm23 commented 4 years ago

Path is mentioned above in this thread.

You should ensure no private / personally identifiable info is in the file (by removing entries using CutBox.)

Do check carefully! Then attach it to a new comment on this thread.

jasonm23 commented 4 years ago

@awreccan https://github.com/cutbox/CutBox/issues/90#issuecomment-522971279

jasonm23 commented 4 years ago

It's important that the file is not modified directly so I can use it to reproduce the crash.

If you have to remove any entries, only do that using CutBox itself, don't edit the file in a text editor.

After removing entries, double check the issue still occurs.

awreccan commented 4 years ago

Gotcha. I had too much sensitive info so I cleared history and now the issue isn't occurring. I suspect it has to do with certain characters in history or a certain number of items in history. Will use as per normal and keep trying fuzzy search, and hopefully come across the bug again.

jasonm23 commented 4 years ago

I suspect it has to do with certain characters in history or a certain number of items in history.

Right, that's the working hypothesis, but we haven't been able to nail it down.

ulfgj commented 4 years ago

managed to get one with a very small sample of clips. info.ocodo.CutBox.plist.txt

the issue sems to be when copying a URL from chrome that expansd afterwards to show the protocol, as seen in the attached screenshot Untitled-1

jasonm23 commented 4 years ago

Is there a reason you are adding .txt ?

ulfgj commented 4 years ago

yup. github didn't allow me to sen .plist files.

On Wed, Oct 23, 2019 at 2:58 PM Jason Milkins notifications@github.com wrote:

Is there a reason you are adding .txt ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KIL4BDBZXGPE66KQNM4LQQBDAXA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBJ4AI#issuecomment-545431041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7KIL6ENTEIC6KXPN4WI5TQQBDAXANCNFSM4IM33WKA .

jasonm23 commented 4 years ago

Ok makes sense

awreccan commented 4 years ago

info.ocodo.CutBox.plist.zip

Some ways to make Cutbox crash with this file:

image

jasonm23 commented 4 years ago

Thanks I'll give it a try today. Hopefully it's going to crash :+1:

On Fri, 25 Oct 2019, 10:41 AM Samdish Suri, notifications@github.com wrote:

info.ocodo.CutBox.plist.zip https://github.com/cutbox/CutBox/files/3770261/info.ocodo.CutBox.plist.zip

Some ways to make Cutbox crash with this file:

  • type htt
  • type s

[image: image] https://user-images.githubusercontent.com/10543509/67541650-58a71280-f71c-11e9-8816-3a37ffd4cdf5.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AAARPI6MCLFSDMC45CAMUCDQQJTG3A5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHCXHY#issuecomment-546188191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAARPIYFBJGIUZD2IQC5ZF3QQJTG3ANCNFSM4IM33WKA .

awreccan commented 4 years ago

@jasonm23 any updates?

awreccan commented 4 years ago

bump

levjad commented 4 years ago

Any updates?

jasonm23 commented 4 years ago

I've had no time to work on this unfortunately.

I should be able to look at it this week at some point.

jasonm23 commented 4 years ago

Successful reproduction of crash.

ulfgj commented 4 years ago

yay!

On Sat, Feb 15, 2020 at 3:14 AM Jason Milkins notifications@github.com wrote:

Successful reproduction of crash.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cutbox/CutBox/issues/90?email_source=notifications&email_token=AA7KIL46G6XXDECK7YVCXODRC5FXLA5CNFSM4IM33WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL27DII#issuecomment-586543521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7KILYIVYS2VTYBL7K3GHLRC5FXLANCNFSM4IM33WKA .

jasonm23 commented 4 years ago

Ok. After a long wait (sorry!) - I've been looking into this again and have a few leads on it. Unfortunately trying to reproduce in a unit test is currently failing.

The dependency I'm relying on is looking a bit dead, so I'm thinking about using an alternative fuzzy match dependency or just spinning my own, probably better to do that in the long run.

https://github.com/yichizhang/SwiftyStringScore/issues/28

jasonm23 commented 4 years ago

Swapping out to use 8Bytes/SwiftyStringScore - works. 1.4.7 pre-release will solve it. Please check when it's available (~10min)

awreccan commented 4 years ago

Works! Thank you this is awesome!

awreccan commented 4 years ago

One problem though ... the search is quite laggy. Wondering if you could add a debounce to the searchbar? https://levelup.gitconnected.com/debounce-in-javascript-improve-your-applications-performance-5b01855e086

jasonm23 commented 4 years ago

@awreccan - please open that as a separate issue.

Thanks for the feedback. (#98)