👋 This PR adds a test for the index.jsgoodFirstIssue file, and makes an attempt at organizing the test files a little differently. I poked around in #1 but didn't see any proposed implementation details, so I just went ahead and put things into a /tests/ folder, which is what I normally do in my own projects.
I've added nock, a wonderful library for mocking network requests. It allows us to not mock the Octokit library, but instead let Octokit do its thing as normal but be given our own fixture data instead of actually reaching out to the GitHub API. This way, we're replacing less code in our tests, and making them more reliable.
If possible, this should be merged before #89 so that I can add some tests into the index.spec.js file, and verify that the appropriate query params are being sent to the Search API.
I also fixed some formatting/whitespace/consistency things 😊 There's more tweaks I want to do (like var => const, wrapping test suites in describe()s) but I don't want this PR to get too difficult to review.
👋 This PR adds a test for the
index.jsgoodFirstIssuefile, and makes an attempt at organizing the test files a little differently. I poked around in #1 but didn't see any proposed implementation details, so I just went ahead and put things into a/tests/folder, which is what I normally do in my own projects.I've added
nock, a wonderful library for mocking network requests. It allows us to not mock the Octokit library, but instead let Octokit do its thing as normal but be given our own fixture data instead of actually reaching out to the GitHub API. This way, we're replacing less code in our tests, and making them more reliable.If possible, this should be merged before #89 so that I can add some tests into the
index.spec.jsfile, and verify that the appropriate query params are being sent to the Search API.I also fixed some formatting/whitespace/consistency things 😊 There's more tweaks I want to do (like
var => const, wrapping test suites indescribe()s) but I don't want this PR to get too difficult to review.