search

cuth / postcss-pxtorem

Convert pixel units to rem (root em) units using PostCSS
MIT License
2.08k stars 172 forks source link

Consider postcss-value-parser #20

Open davidtheclark opened 8 years ago

davidtheclark commented 8 years ago

I thought I'd bring this library to your attention, in case you are interested in using it to replace your pixel-unit-regex: https://github.com/TrySound/postcss-value-parser. Feel free to close if you don't need it, but wanted to make sure it was on your radar.

Nice plugin!

cuth commented 8 years ago

Thanks! This is great, I might use it.

davidtheclark commented 8 years ago

@cuth Funny story. I saw a talk today by @lazd in which we described a Stylus method he had worked out for accomplishing this ... and I thought, "That would be a great PostCSS plugin," ... so I thought about writing it, and I told him about it and he said he might write it ... and then within a few minutes I found that you'd already done it.

cuth commented 8 years ago

@davidtheclark your PostCSS talk slides are great. Thanks for mentioning this plugin in your talk!

niksy commented 5 years ago

@cuth would you be willing to accept PR for this change? I think this could open additional possibilities to improve this plugin (e.g. alternative ways for ignoring properties).

cuth commented 5 years ago

@niksy yes. Sorry for the delayed response!

Ideally, it would pass all the tests and keep the API the same. Even then, I think I would still make it a major version bump just so people have to opt into it.

Thanks for your interest!