update to postcss 8 - Githubissues

cowills commented 3 years ago

Hello, my team at work uses this plugin and we are hoping to update to postcss 8 in the next few months. The plugin migration looked straightforward so i took a shot at it following this migration guide and using this other plugin PR as an example:

https://evilmartians.com/chronicles/postcss-8-plugin-migration https://github.com/Genuifx/postcss-pxtorpx-pro/compare/dev-8

moved postcss to a peerDependency/devDependency
updated the plugin module.exports syntax
moved plugin code into the new Declaration and AtRule functions
replaced decl.parent.insertAfter with decl.cloneAfter

resolves https://github.com/cuth/postcss-pxtorem/issues/66

yangmingshan commented 3 years ago

@cuth Could you spent a little time to review this PR?

cuth commented 3 years ago

Thanks for the ping. I'll review this soon.

cuth commented 3 years ago

Thanks!

cuth commented 3 years ago

Published 6.0.0 for postcss 8

yangmingshan commented 3 years ago

Seems you miss the change log, just a reminder 😀. Thanks for your time.

cuth commented 3 years ago

@yangmingshan you're right, I did. Definitely should call out breaking changes. Thanks!

@yangmingshan would you be interested in being a maintainer? I've gone through too many life changes and don't have much time for open source right now.

yangmingshan commented 3 years ago

Yes I'm interested. My npm username is also yangmingshan.

cuth / postcss-pxtorem

update to postcss 8 #68