Closed jacobtylerwalls closed 2 years ago
This looks very good to me -- nice catch. Do the tests in testHTML look promising to you?
Do the tests in testHTML look promising to you?
The two tests employing maxSystemWidth
both weren't currently working (pitchEditing_long_score and roundCanon), so I think multi-system stuff is still beta-enough that I'm not sure we need to bring those old tests "up to code" to move on with an improvement. Since your comment I have added a js test that fails on master, though.
Before
systemWidthsAndBreaks()
calculates system breaks (againstmaxSystemWidth
) without taking into account new, wider measures from reiterating clef and meter on a new system, which was only done later infixSystemInformation()
.Now The width adjustments need to be performed in the same pass as calculating system widths, so I propose moving the logic into
systemWidthsAndBreaks()
.