cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
144 stars 41 forks source link

RenderOptions should distinguish overridden from transient values #135

Open jacobtylerwalls opened 2 years ago

jacobtylerwalls commented 2 years ago

This is where the renderOptions and some sort of a status marker are in conflict -- we are using "startNewSystem" to mean both "override layout to start new system" and also "in this render should I start a new system?"

_Originally posted by @mscuthbert in https://github.com/cuthbertLab/music21j/pull/126#discussion_r715057579_


We have overriddenWidth but nothing similar for the other render options, so when for instance, systemWidthsAndBreaks() sets left, width, displayClef, etc., we have only true/false values at our disposal, or possibly undefined, not a "never" or "always" or "overridden 400" etc.