search

cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
144 stars 41 forks source link

Typo? #142

Closed ronyeh closed 2 years ago

ronyeh commented 2 years ago

https://github.com/cuthbertLab/music21j/blob/c8afb21a12e52c505ccef772441a3c7282a65bbe/src/vfShow.ts#L654

I'm currently migrating music21j to VexFlow 4. Pretty straightforward so far!

Vex.Flow.Staves (plural)... is that a typo?

mscuthbert commented 2 years ago

Yes. Should just be Stave. Will fix in the v4 PR. Since we're not getting typing from Vexflow at this point it doesn't really matter.

ronyeh commented 2 years ago

I fixed this in PR #172

https://github.com/cuthbertLab/music21j/pull/172/files#diff-4de1d0b7045e52249da4efd9a77bcb9aaa18a906759d0e0f641ccd8b120253d0R702-R705

mscuthbert commented 2 years ago

Fixed in #196