search

cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
144 stars 41 forks source link

stave.glyph_start_x #143

Closed ronyeh closed 2 years ago

ronyeh commented 2 years ago

https://github.com/cuthbertLab/music21j/blob/c8afb21a12e52c505ccef772441a3c7282a65bbe/src/vfShow.ts#L1144

https://unpkg.com/browse/vexflow@1.2.90/src/stave.js

I can't find this instance variable in version 1.2.90 (or 3.0.9). We also don't have it in VexFlow 4.

mscuthbert commented 2 years ago

strange -- Ah! It disappeared in 1.2.38 without notice -- you know...this might explain some things, since 10 + undefined = NaN.

Well, that's why we're switching everything to typescript!

ronyeh commented 2 years ago

I see, the last time it existed was in https://unpkg.com/browse/vexflow@1.2.36/src/stave.js

In 1.2.38, it was renamed to start_x: https://unpkg.com/browse/vexflow@1.2.38/src/stave.js

So you can probably just delete the second part, and set noteOffsetLeft to stave.start_x.

mscuthbert commented 2 years ago

Fixed in #196