search

cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
147 stars 41 forks source link

"tinyNotation:" prefix creates an A #163

Closed jacobtylerwalls closed 2 years ago

jacobtylerwalls commented 2 years ago

Screen Shot 2022-01-14 at 1 52 46 PM

Might explain why this test is written oddly--there are eight notes in the stream, not seven--so the first one does not have an accidental. Should we fix the test or fix the functionality to be like m21p? https://github.com/cuthbertLab/music21j/blob/73e4b4ae045269470e6b4f6421dd0e2e4d60cf65/tests/moduleTests/pitch.ts#L277-L286

jacobtylerwalls commented 2 years ago

Should we fix the test or fix the functionality to be like m21p?

Decided to do both 😄