search

cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
143 stars 41 forks source link

Fix chord accidentals regression #190

Closed jacobtylerwalls closed 2 years ago

jacobtylerwalls commented 2 years ago

Port of cuthbertLab/music21#1323

jacobtylerwalls commented 2 years ago

Looking good, was just checking that I had actually built it locally.

mscuthbert commented 2 years ago

LGTM -- If @vanderstel can give an approval or you've read it twice, happy to merge. Nothing in this at least that seems likely to break anything besides chords.

For functions within functions in Javascript, I have a slight preference for writing them as arrow functions -- maybe it's just old fears of when lots of JS parsers did not handle them well.

vanderstel commented 2 years ago

LGTM