cuthbertLab / music21j

Javascript port of music21 -- Toolkit for Computational Musicology
Other
143 stars 41 forks source link

Fix makeAccidentals regression involving cautionaryPitchClass and chords #194

Closed jacobtylerwalls closed 2 years ago

jacobtylerwalls commented 2 years ago

Before, octaves in chords could receive superfluous accidentals if cautionaryPitchClass was true (default).

190 was incorrectly ported from python: I suppose I wasn't sure if m21j had pitchClass defined, but it does, so I should have just used that as the python implementation (cuthbertLab/music21#1323) does.