Closed jfirebaugh closed 10 years ago
Re: testing as mentioned over here:
Tests should have failed here, too — will fix those.
The reason the tests didn't fail is that we test off of a binary build, the creation process of which requires gl-native
, which is the whole reason we do it this way. Just committing this change doesn't update the contents of ./dist
to change the binary that is tested. I don't see a good way around this (background in https://github.com/mapbox/mapbox-gl-cocoa/issues/35).
Partially done in 453654486d442b2dbc3cae8016332c6378a411dd, but also need to account for unit and sign part of the change.
See https://github.com/mapbox/mapbox-gl-native/pull/350.