search

cutting-room-floor / wax

DEPRECATED: consult mapbox.js
https://github.com/mapbox/mapbox.js
BSD 3-Clause "New" or "Revised" License
167 stars 42 forks source link

Interactivity problem with Leaflet in Chrome Canary #242

Closed alperdincer closed 12 years ago

alperdincer commented 12 years ago

Hi,

I'm using Chrome Canary (22.0.1215.1) for development and I released that wax and leaflet don't work together on this browser.

You can check documentation page (http://mapbox.com/wax/interaction-leaf.html) on Chrome Canary to see what's going on.

Alper.

tmcw commented 12 years ago

Can you see the problem in Chrome release cycle? This appears to work for me in Chrome Beta, and I'd rather not fix pre-release bugs in Chrome, of which there are many.

alperdincer commented 12 years ago

There is no problem with Chrome Beta (version 21.0.1180.49 beta)

I just want to inform you about the issue.

Thanks a lot.

tmcw commented 12 years ago

Thanks, hopefully Google catches it before it lands :)

dooley commented 12 years ago

Unfortunatly not, Chrome Version 22.0.1229.79 (Win7) as well as latest stable version on Ubuntu has the problem from above. Any workaround?

javierarce commented 12 years ago

Same thing in Chrome for mac. I'm currently using Chrome 22.0.1229.91 beta, but there are problems in the stable channel too.

javisantana commented 12 years ago

the problem is with wax.offset, if you use $(el).offset return different values.

A quick fix (not tested in IE)

https://github.com/CartoDB/wax/commit/08b82471c1eee79349388b67978ac23282d6ec1b

dooley commented 12 years ago

@ javisantana: Great, works without sideeffect in Chrome, Firefox, IE on Win7 (latest versions). Thanks for that!

javisantana commented 12 years ago

@dooley thanks for testing.

also that fix solves some problems wax had with fixed positions on elements in the html page.

we have some testing for libraries that use wax, maybe is a good idea to "backport" them to wax to test this kind of things on different browser/OS/devices

tmcw commented 12 years ago

@javisantana can you provide this as a pull request?

javisantana commented 12 years ago

done

tmcw commented 12 years ago

Pull request merged.

miketahani commented 12 years ago

Fix worked for me, but it looks like the changes haven't made their way into dist/ on master. Thanks!

javisantana commented 12 years ago

we have been using it extensively past months without any problem, i consider it fixed

tmcw commented 12 years ago

Rebuilt and pushed in 1424765a8759fd76f7bb9388b430df4e082c2949