search

cutting-room-floor / wax

DEPRECATED: consult mapbox.js
https://github.com/mapbox/mapbox.js
BSD 3-Clause "New" or "Revised" License
167 stars 42 forks source link

Remove interaction function problem in Gmapsv3 #248

Closed xavijam closed 12 years ago

xavijam commented 12 years ago

I'm trying to remove the interaction in Google maps, but it's failing. Here is one of your examples:

http://vizzuality.github.com/cartodb-gmapsv3/wax-bug.html

If you try in the console:

interaction.remove();

Fails and say:

TypeError: Object # has no method 'remove'

PS: With Leaflet is working properly.

wboykinm commented 12 years ago

I see Javier caught exactly the same issue I just stumbled on. using interaction.remove(); to push the next interactivity in a layer switcher results in the same TypeError: Object # has no method 'remove' error.

wboykinm commented 12 years ago

I see that Javier 7 (how do you guys not get confused over there? - @javisantana) may have solved it. Here's his update to interaction.js. @tmcw or @willwhite - can either of you push this in tomorrow?

javisantana commented 12 years ago

@wboykinm hey, i didn't realize @xavijam was posted this bug. I found this some weeks ago, fixed it in out wax version and i forgot to send a pull request.

willwhite commented 12 years ago

Can you make a pull request with the fix?

javisantana commented 12 years ago

@willwhite sure, give a minute

javisantana commented 12 years ago

done https://github.com/mapbox/wax/pull/263