Feat #1036 enter lobby after room creation

cuttle-cards / cuttle

A two-player battle card game for all ages, built with nodejs, sailsjs, and vuejs

MIT License

145 stars 115 forks source link

Feat #1036 enter lobby after room creation #1079

Closed piotrziolko closed 1 month ago

piotrziolko commented 1 month ago

Issue number 1036

Relevant issue number

Resolves #https://github.com/cuttle-cards/cuttle/issues/1036

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[ ] Is the code formatted properly? (see Linting (Formatting))
For New Features:
- [ ] Have tests been added to cover any new features or fixes?
- [ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change

Haviles04 commented 1 month ago

Nice work, this will be a nice improvement :). I think we're likely going to need to update some test now that it will navigate you to the lobby view. specifically it('Creates a new game by hitting enter in text field',()=>{}) in specs/out-of-game/home.spec.js

If you have any questions you can reach out in the #code channel of our Discord

piotrziolko commented 1 month ago

Nice work, this will be a nice improvement :). I think we're likely going to need to update some test now that it will navigate you to the lobby view. specifically it('Creates a new game by hitting enter in text field',()=>{}) in specs/out-of-game/home.spec.js

If you have any questions you can reach out in the #code channel of our Discord

tests updated