search

cvan / keyboardevent-key-polyfill

polyfill for `KeyboardEvent.prototype.key`
https://cvan.io/keyboardevent-key-polyfill/
Creative Commons Zero v1.0 Universal
47 stars 15 forks source link

Set property enumerable and configurable #6

Closed qgustavor closed 6 years ago

qgustavor commented 8 years ago

Using Object.getOwnPropertyDescriptor(KeyboardEvent.prototype,'key'); on a browser which implements KeyboardEvent.prototype.key shows that property is enumerable and configurable. The polyfill don't set those two descriptors breaking code that rely on those.

cvan commented 6 years ago

sorry just seeing this now. awesome, thanks for the find and the fix.