search

cvangysel / pytrec_eval

pytrec_eval is an Information Retrieval evaluation tool for Python, based on the popular trec_eval.
http://ilps.science.uva.nl/
MIT License
282 stars 32 forks source link

Windows support, Github Actions #27

Closed cmacdonald closed 4 years ago

cmacdonald commented 4 years ago

Dear all, please consider this PR for review. This patch:

  1. uses a version of trec_eval that compiles under native Windows (using the Visual Studio build tools). I am sending those patches to NIST for inclusion in trec_eval.
  2. fixes Windows compilation for pytrec_eval
  3. includes Github Actions continuous integration testing for Linux, Mac and Windows. You can see the output at https://github.com/cmacdonald/pytrec_eval/actions/runs/138328941
  4. Includes the fixes for #23, which I have #ifdef'd around, as they didn't work for VS.

Perhaps once NIST have merged (1), we should be able to merge this, and plan to make a pypi Windows wheel.

It took a lot of attempts to get the Action workflow yml file correct, so perhaps squash merge would be appropriate.

cmacdonald commented 4 years ago

Hello @cvangysel any news?

cmacdonald commented 4 years ago

bump. I note that v9.0.8 release of trec_eval includes my patches to build on Windows, so I have updated the source tar file mentioned in the pull request.