Closed SpecLad closed 2 weeks ago
[!IMPORTANT]
Review skipped
Auto incremental reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates primarily focus on removing the framework
property and related references across various files in the CVAT project. This change affects multiple components, including the MLModel
class, lambda functions, and serverless configurations for different models. The overall goal is to streamline the codebase by eliminating the framework
metadata, potentially simplifying model management and deployment processes.
File(s) / Group | Change Summary |
---|---|
cvat-core/src/ml-model.ts |
Removed framework property from MLModel class. |
cvat/apps/lambda_manager/views.py |
Removed framework , state , and attributes references in LambdaFunction . |
serverless/.../nuclio/function.yaml |
Removed framework annotations from various model configurations. |
site/content/en/docs/.../tutorial.md |
Removed framework: pytorch from the serverless tutorial metadata. |
In the code where models roam, Framework tags no longer home. Simplified and clean they stand, Guided by a coder's hand. Models now, free to soar, With less to track, they do much more!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Failed conditions
13.9% Duplication on New Code (required ≤ 3%)
Motivation and context
Remove several fields that haven't been used for one reason or another:
labels
andattributes
have been replaced bylabels_v2
. Keeping them around nearly triples the response length.framework
hasn't been used by the UI since #5635, and IMO was never useful to begin with. There are no decisions that the UI can take based on this field, so it's essentially just a freeform text field, and we already have a freeform text field -description
. (Which... the UI doesn't display either. But it could!)Remove the
framework
field from the function descriptions as well, since it has no other purpose.state
has, as far I could determine, never been used by the UI. I could see a field like this potentially being useful (e.g. the UI could still display a function, but prevent it from being used if it's unavailable), but since none of that is implemented right now, I see no reason to have this field in the API.How has this been tested?
Checklist
develop
branchLicense
Summary by CodeRabbit
Refactor
Documentation
framework: pytorch
entry for the RetinaNet R101 detector.