Add propagate shapes action

klakhov commented 1 week ago

Motivation and context

The PR adds new action Propagate shapes that allows to propagate all filtered shapes on the current frame simultaneously

How has this been tested?

Manual testing

Checklist

[x] I submit my changes into the develop branch
[x] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
~~[ ] I have linked related issues (see GitHub docs)~~
[x] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features
- Introduced a new "Propagate Shapes" action to enable simultaneous propagation of filtered shapes across frames.
Updates
- Updated version numbers for cvat-core to 15.0.7 and cvat-ui to 1.63.12 indicating a new release.
Enhancements
- Improved annotation workflows with the addition of frame selection types and enhanced frame selection handling in the UI.
- Conditional rendering and disabling of frame input fields based on the active frame selection type.

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update introduces the Propagate Shapes action in CVAT, allowing simultaneous propagation of filtered shapes across frames. Changes include adding the PropagateShapes class, related types, and enums in annotations-actions.ts, the propagateShapes function in object-utils.ts, and accommodating user interface adjustments in the annotations-actions-modal.tsx. Updates also involved incrementing version numbers for cvat-core and cvat-ui.

Changes

File	Summary
changelog.d/..._propagate_shapes_simultaneously.md	Introduced a documentation file summarizing the new `Propagate shapes` action.
cvat-core/package.json	Bumped version from `15.0.6` to `15.0.7` to indicate a new feature release.
cvat-core/src/annotations-actions.ts	Added the `PropagateShapes` class, `FrameSelectionType` enum, and updated `BaseSingleFrameAction` class.
cvat-core/src/object-utils.ts	Introduced the `propagateShapes` function to handle shape propagation between frames.
cvat-ui/package.json	Incremented version from `1.63.11` to `1.63.12` for a minor UI update.
cvat-ui/src/components/.../annotations-actions-modal.tsx	Enhanced the modal to support `FrameSelectionType` and updated related UI/logic components.
cvat-ui/src/cvat-core-wrapper.ts	Added `FrameSelectionType` to `BaseSingleFrameAction` import and updated exported entities accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI as CVAT UI
    participant Core as CVAT Core

    User->>UI: Opens annotations modal
    UI->>Core: Initialize PropagateShapes action
    Core->>UI: Provide frame selection options
    User->>UI: Select frame range and shapes to propagate
    UI->>Core: Call propagateShapes function with selected frames and shapes
    Core->>UI: Return propagated shapes data
    UI->>User: Display updated shapes on frames

Poem

🐇 In CVAT's world so bright and clear,
Frames now sync, there's no more fear,
Shapes propagate from frame to frame,
Simplifying tasks, enhancing the game.
With versions ticked up just a bit,
Shape your work with ease and wit!
🌟✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bsekachev commented 4 days ago

Default value for target frame "0" is useless as I am already on the same frame. I will propose to use the same default values as we use in default propagation functionality (+50 or -50 frames as I remember depending on possible propagation directions).
Also when I am on frame 0 and target frame is 0, running propagate action freezes the browser (infinite loop?)
Found a difference in behavior how masks are propagated using default propagation and actions. Example:
- First frame is 1000x1000, mask is on [900:1000, 900:1000].
- Second frame is 500x500.
- Propagate, using classic way: empty masks are created at top left corner. But export to Segmentation mask format works.
- Propagate, using action: masks are copied, but outside of the frame. As result export to Segmentation mask format does not work.

I am not sure, that copies in both cases are correct, but the second case creates more issues, not allowing to export task.

bsekachev commented 4 days ago

Also, please, add tests to cover found issues.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 87.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (78fa7cf) to head (b56bbf7). Report is 11 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #8044 +/- ## =========================================== + Coverage 83.62% 83.63% +0.01% =========================================== Files 383 383 Lines 40439 40503 +64 Branches 3815 3831 +16 =========================================== + Hits 33817 33875 +58 - Misses 6622 6628 +6 ``` | [Components](https://app.codecov.io/gh/cvat-ai/cvat/pull/8044/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cvat-ai) | Coverage Δ | | |---|---|---| | [cvat-ui](https://app.codecov.io/gh/cvat-ai/cvat/pull/8044/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cvat-ai) | `79.67% <87.50%> (+0.08%)` | :arrow_up: | | [cvat-server](https://app.codecov.io/gh/cvat-ai/cvat/pull/8044/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cvat-ai) | `87.25% <ø> (-0.05%)` | :arrow_down: |

klakhov commented 3 days ago