Closed bsekachev closed 5 days ago
[!IMPORTANT]
Review skipped
Auto incremental reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent changes involve updates to the cvat-core
and cvat-ui
files relating to project subset handling. The taskSubsets
property in the Project
class has been renamed to subsets
, and adjustments were made to component props and logic to accommodate this change and handle subsets more appropriately, especially when dealing with null values.
File Path | Change Summary |
---|---|
cvat-core/src/project.ts |
Renamed taskSubsets to subsets in the Project class. |
cvat-ui/src/components/create-task-page/create-task-content.tsx |
Added projectSubsets prop with a value of null to ProjectSubsetField component. |
cvat-ui/src/components/create-task-page/project-subset-field.tsx |
Changed projectSubsets type and adjusted conditional logic related to it. |
cvat-ui/src/components/task-page/details.tsx |
Updated imports, restructured mapStateToProps , removed projectSubsets , adjusted logic. |
In fields of code where subsets play,
We named them new to clear the way.
With props and types now clear and true,
The tasks and projects thrive anew.
A bunny's cheer for changes made,
In CVAT's core a smoother grade!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Motivation and context
Requests before fix when changing job stage (task in a project, project not in app state):![image](https://github.com/cvat-ai/cvat/assets/40690378/a3d80e00-f628-47b2-ba00-52069102ee93)
After fix:![image](https://github.com/cvat-ai/cvat/assets/40690378/c47c757c-79d8-442c-b66b-01c2f7cece6c)
How has this been tested?
Checklist
develop
branchLicense