k700_2020_downloader.sh

cvdfoundation / kinetics-dataset

758 stars 96 forks source link

k700_2020_downloader.sh #24

Closed sawyermade closed 2 years ago

sawyermade commented 2 years ago

This file is all kinds of wrong. First off, uses sudo for everything and then also downloads all the files twice. I will fix it and do a pull request. This is really, really bad.

kinetics-cvdf commented 2 years ago

Thank you, shame on me but don't have much time or skill to verify these things. Looking forward to your contribution.

TengdaHan commented 2 years ago

@sawyermade Thank you for fixing it. Your contribution will be greatly appreciated!

sawyermade commented 2 years ago

No problem. I will be doing a pull request by the end of the day. Already have the downloader fixed, with resume and everything. Going to create a separate script for extracting (shouldn't do all in one) and keep your current naming convention. I will also update the readme as well with instructions on how to complete k700-2020 video download and extraction.

Also, would you like me to write a frame extract script as well? In order to extract the frames from all the downloaded videos.

Really nice aws repo though, much better than the youtube-dl methods due to deleted videos and such.

TengdaHan commented 2 years ago

Hi @sawyermade

about the scripts and readme -- Thanks again!
"write a frame extract script" -- Maybe let's avoid this for simplicity of this repo? There are many good video loaders available and there are so many variations when extracting frames.

Best wishes.

sawyermade commented 2 years ago

Okay cool, I will just do the pull request for download and extraction. I'll still write the script for frame extraction and push it to my forked repo then send you a link to it so you can check it out, if you guys approve, I'll make a pull request for that too.

sawyermade commented 2 years ago

Created the pull request for the downloader, extractor, and readme. Everything seems to work well!