search

cvdlab / react-planner

:pencil2: A React Component for plans design. Draw a 2D floorplan and navigate it in 3D mode.
https://cvdlab.github.io/react-planner
MIT License
1.28k stars 456 forks source link

Feature/add export #171

Closed JaccoGoris closed 1 year ago

JaccoGoris commented 5 years ago

Added the ability to extract a 3D Collada file from the scene. Reworked the way the walls are built because the way it was done was causing a lot of shading issues in other 3D software

Fix for #167

JaccoGoris commented 5 years ago

We moved our fork to the organisation, that's why this one is coming from "around media"

JaccoGoris commented 5 years ago

Updated my PR since the newest version of three allows the use of imports for the examples (finally) this is necessary because else the planner could not be used as a lib anymore.

danilosalvati commented 5 years ago

Sorry for the late response but I was very busy in these days... I am not fully convinced by your pull requests, so I will try to accomplish same results with little modifications of your code base... In particular I was able to obtain an empty collada scene as the setTimeout was invoked before the scene parsing was complete

JaccoGoris commented 5 years ago

@danilosalvati, No problem at all! Since then I had found a couple of the same issues, and I've reworked it a bit already, there's a timeout now and I've changed to logic to work as an Action, rather than putting the functionality straight in the export button. it works much better now.

Though, for my tests when using it in a create react app: having the texture in the mtl file is problematic as it doesn't find it and the export fails. so that might have to change in the future.

do you still want me to update my PR or do you want to try yourself?

danilosalvati commented 5 years ago

I have an idea I would like to test... so I think I will try myself for now

JaccoGoris commented 5 years ago

Okay! very well :)

ericvanular commented 4 years ago

@danilosalvati thanks for your work on this project. Can you please merge some of the awesome features @JaccoGoris has built here? Alternatively, the project will likely continue on a new fork