cvengler / sysget

One package manager to rule them all
GNU General Public License v3.0
683 stars 35 forks source link

Improved Security; Cosmetic fix. #30

Closed jackrendor closed 5 years ago

jackrendor commented 5 years ago

Tested and compiled on Fedora release 28 (Twenty Eight).

In this pull request I changed few things:

cvengler commented 5 years ago

Thank you for your PR! secure_getenv() is not working on macOS, is there an alternative which also works on Darwin ?

cvengler commented 5 years ago

According to the manual secure_getenv() is a GNU extension. so it isn't a standard function What do you think is it really essential to use secure_getenv().

jackrendor commented 5 years ago

I'm sorry to hear that. And I hope you can apologize me for being late. I'll make it execute secure_getenv instead of getenv only when compiling on Linux. Is it ok for you? I'll wait for your instructions before pushing.

cvengler commented 5 years ago

Can you show me a prototype of this ? If yes I'm fine with it.

jackrendor commented 5 years ago

Sure. I'll be happy to show it and explain it too.

image

cvengler commented 5 years ago

Sorry that it took me so long to answer. Thank you for your contribution to sysget. I will merge!

jackrendor commented 5 years ago

Do not worry about the delay! I'm happy you appreciated the edit! ^^ Happy Coding!