cversek / python-FLI

Python bindings for Finger Lakes Instrumentation (FLI) cameras and peripherals.
MIT License
10 stars 11 forks source link

fixed bug UnboundLocalError: local variable 'i' referenced before ass… #6

Closed tzuchiangshen closed 8 years ago

tzuchiangshen commented 9 years ago

Hi Cversek:

Thank you very much for maintaining this piece of software. I found a tiny bug, Hope you can merge it back.

import FLI cams = FLI.camera.USBCamera.find_devices() Traceback (most recent call last): File "", line 1, in File "FLI/device.py", line 56, in find_devices while tmplist[i]: #process members only if they are not NULL UnboundLocalError: local variable 'i' referenced before assignment

Regards,

Tzu

cversek commented 8 years ago

Thanks for offering this bug-fix. Sorry I didn't see it a year ago, I was busy with other projects and it probably got swamped in my email box. BTW, I am not associated with FLI, nor do I currently have access to any of their devices. Furthermore, the project for which this code was written ~3 years ago was sidelined by the US government shutdown. Needless to say, I am not in an ideal position to maintain this project - so, if you are, then I can point people towards your branch. Feel free to send me an email and let me know what exciting project with which you are integrating this little package!

tzuchiangshen commented 8 years ago

Hi Cverserk,
Our project are using a FLI camera for a spectrograph. It was just installed in a 1m class telescope in la Silla Observatory in Chile.

see :
https://www.eso.org/public/announcements/ann16046/ https://www.ing.uc.cl/centro-de-astro-ingenieria-de-la-uc-elabora-primer-instrumento-chileno-instalado-en-observatorio-internacional/

I have to maintain the code anyway for our project, so please feel free to forward other people to me, I will do my best to help them.

Regards,

Tzu

cversek commented 8 years ago

Awesome, I'm glad to be able to help out other scientists. I wish you luck with your project.