Menu style inconsistencies

cvfosammmm / Setzer

LaTeX editor written in Python with Gtk

https://www.cvfosammmm.org/setzer/

Other

385 stars 33 forks source link

Menu style inconsistencies #370

Closed kinten108101 closed 10 months ago

kinten108101 commented 10 months ago

Popover menus in this app do not share the same style with other GTK apps, especially recent ones which use the style from Adwaita.

This app uses a custom popover menu solution (popover_menu_builder.py). This solution relies on GtkButton and other custom elements to craft menu while most apps use GioMenu to layout the menu then the library handles the rest of the UI.

I wonder if there's a reason why we use a custom popover menu solution in the first place?

I'm currently experimenting with GioMenu in my fork. If needed, I am ready to take on the task of migrating to GioMenu.

cvfosammmm commented 10 months ago

Using widgets to construct the menus is more flexible. I think it's also quite efficient and expressive. I see no reason to move away from it.

kinten108101 commented 10 months ago

It's not an efficiency problem but more of a design problem.

Setzer: setzer-menu

GNOME Calender: gcal-menu

Fragments: fragment-menu

Differences are:

"submenu arrow", this app uses pan-end/start-symbolic while other apps use right/left-symbolic
Padding for menu items
Font weight (shortcut text)

These differences are small, but it'd be nice for this app to share a consistent style with other apps.

While changes can be made to style_gtk.css and app code, a future-proof solution would be to use what GTK provides by default.

cvfosammmm commented 10 months ago

Thanks for pointing this out. I think the benefits from a custom solution are more important in this case.