cvg / Hierarchical-Localization

Visual localization made easy with hloc
Apache License 2.0
2.96k stars 551 forks source link

Pycolmap update breaks the existing sift pipeline. #351

Closed prasad-pr-20 closed 5 months ago

prasad-pr-20 commented 5 months ago

The SIFT based DOG extractor class model in hloc/extractors/dog.py seems to be now broken becuase of the update in the pycolmap. With pycolmap 0.5.0, pycolmap.sift.extract returns only two parameters while three are expected in the current code. keypoints, scores, descriptors = self.sift.extract(image_np)

We get the error

ValueError: not enough values to unpack (expected 3, got 2)

Any thoughts or suggestions as to how do we overcome the same, is greatly appreciated. Thanks in advance.