Adding basic CI and fixing minor problems - Githubissues

cvg / glue-factory

Training library for local feature detection and matching

Apache License 2.0

722 stars 90 forks source link

Adding basic CI and fixing minor problems #17

Closed iago-suarez closed 11 months ago

iago-suarez commented 11 months ago

This PR contains integration tests that check that LG and GS keep working and also fix some minor bugs:

Integration tests checking the accuracy of homography estimation
Removing unused conf parameter from eval_matches_homography
Expecting all data to be batched/non-batched in eval_matches_homography, eval_homography_robust, eval_homography_dlt
Converting pose estimation evaluation to torch and fixing a bug in the return order!
Removing .cuda() in the lightglue_pretrained constructor

Please check the code and just let me know if you agree with these changes :smiley:

iago-suarez commented 11 months ago

Thanks for the review Paul! It is very cool that we have automatic tests, I will sleep better now 😅