cvg / glue-factory

Training library for local feature detection and matching
Apache License 2.0
722 stars 90 forks source link

Allow SuperPoint_Open weights to be loaded from local cache #68

Closed aduverger closed 6 months ago

aduverger commented 6 months ago

Hello, This PR addresses an issue we encounter when having to use SuperPoint in a production environment. Currently, the pre-trained model weights MUST be downloaded from https://github.com/rpautrat/SuperPoint/raw/master/weights/superpoint_v6_from_tf.pth.

This is not compatible with a production env:

This PR allows the users to specify a weights parameter in the config input (similar to LightGlue), so that the weights are loaded from cache instead of from rpautrat's repo.

aduverger commented 6 months ago

Anyone could have a look at this PR please :) ? @sarlinpe, @Phil26AT, @rpautrat

sarlinpe commented 6 months ago

Nice, thank you! And apologies for the late reply.